BREAKING CHANGE(AppearanceProvider): replace appearance with value #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e4b6a6:
|
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6147 +/- ##
==========================================
- Coverage 79.66% 79.52% -0.15%
==========================================
Files 316 315 -1
Lines 9919 9870 -49
Branches 3333 3333
==========================================
- Hits 7902 7849 -53
- Misses 2017 2021 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Nov 27, 2023
inomdzhon
approved these changes
Nov 27, 2023
| ✅ v6.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Unit-тесты- [ ] e2e-тесты- [ ] Дизайн-ревью- [ ] Документация фичиОписание
В остальные провайдеры (
PlatformProvider,LocaleProvider) прокидываемvalue, для консистентность нужно сделать также дляAppearanceProviderИзменения
Заменила проп + добавила ссылку на гайд миграции в стайлгайде