refactor: migration_v6.md #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Добавил блок "Содержание". Для это в Styleguide добавил возможность навигироваться по заголовкам. - Отформатировал текста. - Изменил структуру.
👀 Docs deployed
Commit aa93aad |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa93aad:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6238 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 324 324
Lines 10091 10091
Branches 3386 3386
=======================================
Hits 8188 8188
Misses 1903 1903
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
previously approved these changes
Dec 8, 2023
BlackySoul
previously approved these changes
Dec 8, 2023
BlackySoul
previously approved these changes
Dec 8, 2023
SevereCloud
approved these changes
Dec 8, 2023
BlackySoul
approved these changes
Dec 8, 2023
inomdzhon
added a commit
that referenced
this pull request
Dec 13, 2023
Используем `lodash` и `react-children-utilities`. - caused by #6238
inomdzhon
added a commit
that referenced
this pull request
Dec 13, 2023
inomdzhon
added a commit
that referenced
this pull request
Dec 13, 2023
#6273) h2. Описание Исправил техдолги: - Удалил `styleguide/utils/thirt-party/`, затащив `lodash` и `react-children-utilities`. В #6238 делал решение в лоб. - В `styleguide/Components/Heading/HeadingRenderer.js` заменил `<Headline level="1" />` на `<Title level="3" />`, чтобы заголовок третьего уровня был более акцентным по сравнению с текстом этого раздела. h2. Изменения - Добавил `tsconfig.json`. Из-за того, что нет `tsconfig.json` в VSCode не работал ESLint. - caused by #4250 - `migration_v6.md` – поправил текст в `Компоненты | Accordion`, чтобы не было дублирования названия компонента. - Поправил уровень заголовков в `ModalRoot`, `Slider` и `Tabs`.
| ✅ v6.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Изменения
stylguide/utils/third-partyдобавил несколько утилит, которые помогают конвертировать любой текст вkebab-case. ЗабралkebabCaseизlodash, аgetTextFromChildrenизreact-children-utils(скорее копипастнул изpackages/vkui/lib/children).