feat(e2e): add ability to add value with label to screenshot #8147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit e7ea2b9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8147 +/- ##
==========================================
- Coverage 95.50% 95.49% -0.01%
==========================================
Files 401 403 +2
Lines 11435 11456 +21
Branches 3774 3781 +7
==========================================
+ Hits 10921 10940 +19
- Misses 514 516 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Jan 20, 2025
packages/vkui/src/components/UsersStack/UsersStack.e2e-playground.tsx
Outdated
Show resolved
Hide resolved
BlackySoul
approved these changes
Jan 21, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/decrease-screenshots-volume
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
withLabel, которая позволяет на скриншоте вместо значения указывать кастомныйlabel. Это может понадобится, когда вvalueнаходится очень длинный текст и на мобильном экране он занимает много места. В то же время знать полностью все значение нам в большинстве случаев не надо. Поэтому можно добавить кастомный короткийlabel.withLabelРазмер скриншотов
до изменений: 112,21 MB
после изменений: 104,93 MB
Release notes