feat(DateInput): add placeholder prop #8168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit beee192 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8168 +/- ##
==========================================
+ Coverage 95.49% 95.50% +0.01%
==========================================
Files 403 403
Lines 11503 11507 +4
Branches 3812 3815 +3
==========================================
+ Hits 10985 10990 +5
+ Misses 518 517 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-android-chromium-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-android-chromium-light-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-ios-webkit-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-ios-webkit-light-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-firefox-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-firefox-light-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-webkit-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-webkit-light-1-snap.png
inomdzhon
reviewed
Jan 21, 2025
qurle
previously approved these changes
Jan 27, 2025
# Conflicts: # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-android-chromium-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-android-chromium-light-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/DateInput/__image_snapshots__/dateinput-vkcom-chromium-light-1-snap.png
EldarMuhamethanov
dismissed stale reviews from qurle and andrey-medvedev-vk
via
4467867
EldarMuhamethanov
requested review from
andrey-medvedev-vk,
qurle and
inomdzhon
andrey-medvedev-vk
previously approved these changes
Jan 27, 2025
…/date-input-placeholder # Conflicts: # packages/vkui/src/components/DateInput/DateInput.test.tsx
inomdzhon
previously approved these changes
Jan 28, 2025
EldarMuhamethanov
dismissed stale reviews from inomdzhon and andrey-medvedev-vk
via
beee192
andrey-medvedev-vk
approved these changes
Jan 28, 2025
inomdzhon
approved these changes
Jan 28, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/6040/date-input-placeholder
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Нужно добавить отображение
placeholder- текст, который будет отображаться при пустом значенииvalueИзменения
renderCustomValue, которое позволяет отрендерить кастомный текст в зависимости от значения в полеRelease notes
Улучшения
renderCustomValue, которое позволяет отрендерить кастомный текст в зависимости от значения в поле