Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Image): add prop filter #8171

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Jan 21, 2025


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Необходимо добавить свойство filter для компонента Image/ImageBase

Release notes

Улучшения

  • Image: добавлено свойство filter, которое применяет одноименный стиль к изображению

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner January 21, 2025 09:34
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 392.43 KB (+0.03% 🔺)
JS (gzip) 119.02 KB (+0.02% 🔺)
JS (brotli) 97.99 KB (+0.15% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 344.21 KB (+0.06% 🔺)
CSS (gzip) 42.66 KB (+0.06% 🔺)
CSS (brotli) 33.99 KB (-0.05% 🔽)

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.48%. Comparing base (caa1e30) to head (146605d).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8171      +/-   ##
==========================================
- Coverage   95.50%   95.48%   -0.02%     
==========================================
  Files         401      401              
  Lines       11435    11441       +6     
  Branches     3774     3780       +6     
==========================================
+ Hits        10921    10925       +4     
- Misses        514      516       +2     
Flag Coverage Δ
unittests 95.48% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@EldarMuhamethanov EldarMuhamethanov merged commit bff743b into master Jan 23, 2025
28 of 29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7754/image-filter-prop branch January 23, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: css filter для Image
3 participants