patch: pr8247 #8260
Merged
patch: pr8247 #8260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrey-medvedev-vk
commented
Feb 12, 2025
andrey-medvedev-vk
commented
- patch fix(OnboardingTooltip): a11y #8247
- Добавил FocuTrap чтобы фокус сразу попадал в OnboradingTooltip для пользователей скринридеров. - Сделал `overlay` прозрачной кнопкой, чтобы можно было по нажатию на неё закрыть `OnboardingTooltip` и передвинул его DOM-дереве перед контентом тултипа, чтобы он не перекрывал весь текст тултипа. - Добавил `role="dialog"` и `aria-modal="true"` чтобы пользователь скринридера не мог выйти за пределы тултипа пока его не закроет. - Добавил warning если title/aria-label/aria-labelledby не заданы
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.1-stable #8260 +/- ##
==============================================
+ Coverage 95.53% 95.57% +0.03%
==============================================
Files 397 397
Lines 11360 11367 +7
Branches 3753 3757 +4
==============================================
+ Hits 10853 10864 +11
+ Misses 507 503 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 3410454 |
EldarMuhamethanov
approved these changes
Feb 12, 2025
inomdzhon
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.