fix(desktop): Replace reflection based behaviours

VMelnalksnis · Feb 11, 2024 · 51e2f6d · 51e2f6d
1 parent 0983310
commit 51e2f6d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/docs/changelog.html b/docs/changelog.html
@@ -44,7 +44,7 @@
 
 <main id="top" class="content">
 	<h1>Changelog</h1>
-	<section id="unreleased" hidden="hidden">
+	<section id="unreleased">
 		<div>
 			<a style="display: inline" href="#unreleased"><img src="link.png" alt="link"/></a>
 			<h2 style="display: inline">Unreleased</h2>
@@ -70,9 +70,15 @@ <h3>Removed</h3>
 			<ul></ul>
 		</section>
 
-		<section id="unreleased_fixed" hidden="hidden">
+		<section id="unreleased_fixed">
 			<h3>Fixed</h3>
-			<ul></ul>
+			<ul>
+				<li>
+					Trimming related issues introduced in last version in
+					<a href="https://github.com/VMelnalksnis/Gnomeshade/pull/1085">#1085</a> and
+					<a href="https://github.com/VMelnalksnis/Gnomeshade/pull/1086">#1086</a>
+				</li>
+			</ul>
 		</section>
 
 		<section id="unreleased_security" hidden="hidden">

diff --git a/source/Gnomeshade.Desktop/Views/Reports/CategoryReportView.axaml b/source/Gnomeshade.Desktop/Views/Reports/CategoryReportView.axaml
@@ -23,9 +23,9 @@
 			IsEnabled="{Binding !IsBusy}">
 
 			<Interaction.Behaviors>
-				<EventTriggerBehavior EventName="SelectionChanged" SourceObject="{Binding #Aggregate}">
+				<RoutedEventTriggerBehavior RoutedEvent="{x:Static AutoCompleteBox.SelectionChangedEvent}" SourceInteractive="Aggregate">
 					<InvokeCommandAction Command="{Binding RefreshAsync}" />
-				</EventTriggerBehavior>
+				</RoutedEventTriggerBehavior>
 			</Interaction.Behaviors>
 		</AutoCompleteBox>
 

diff --git a/source/Gnomeshade.Desktop/Views/Reports/ProductReportView.axaml b/source/Gnomeshade.Desktop/Views/Reports/ProductReportView.axaml
@@ -33,9 +33,9 @@
 					</AutoCompleteBox.ItemTemplate>
 
 					<Interaction.Behaviors>
-						<EventTriggerBehavior EventName="SelectionChanged" SourceObject="{Binding #Aggregate}">
+						<RoutedEventTriggerBehavior RoutedEvent="{x:Static AutoCompleteBox.SelectionChangedEvent}" SourceInteractive="Aggregate">
 							<InvokeCommandAction Command="{Binding UpdateSelectedAggregate}" />
-						</EventTriggerBehavior>
+						</RoutedEventTriggerBehavior>
 					</Interaction.Behaviors>
 				</AutoCompleteBox>
 
@@ -55,9 +55,9 @@
 					</AutoCompleteBox.ItemTemplate>
 
 					<Interaction.Behaviors>
-						<EventTriggerBehavior EventName="SelectionChanged" SourceObject="{Binding #Calculator}">
+						<RoutedEventTriggerBehavior RoutedEvent="{x:Static AutoCompleteBox.SelectionChangedEvent}" SourceInteractive="Calculator">
 							<InvokeCommandAction Command="{Binding UpdateSelectedAggregate}" />
-						</EventTriggerBehavior>
+						</RoutedEventTriggerBehavior>
 					</Interaction.Behaviors>
 				</AutoCompleteBox>
 			</StackPanel>
@@ -74,9 +74,9 @@
 						IsEnabled="{Binding !IsBusy}">
 
 						<Interaction.Behaviors>
-							<EventTriggerBehavior EventName="SelectionChanged" SourceObject="{Binding #Product}">
+							<RoutedEventTriggerBehavior RoutedEvent="{x:Static AutoCompleteBox.SelectionChangedEvent}" SourceInteractive="Product">
 								<InvokeCommandAction Command="{Binding UpdateSelectedProduct}" />
-							</EventTriggerBehavior>
+							</RoutedEventTriggerBehavior>
 						</Interaction.Behaviors>
 					</AutoCompleteBox>