Add: Mecab_load_with_userdicを追加 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sevenc-nanashi PRありです！！ もし知ってたらお聞きしたいのですが、この関数がなくてもpyopenjtalkの方はuserdicを読み込めてたのはなぜなんでしょう･･･？ |
|
ユーザー辞書指定がなければMecab_load、指定されていたらMecab_load_with_userdic（のようなもの）をCPythonで実装、のようになっています。 |
Hiroshiba
requested changes
Jul 9, 2023
|
あ、pyopenjtalk側もこれ使うようにするのが良いかもですかね。 |
|
レビューを反映しました。
確かに。良さそう。 |
takana-v
approved these changes
Jul 10, 2023
|
Approve集まったのでマージします。 |
qryxip
reviewed
Jul 11, 2023
| return Mecab_load_with_userdic(m, dicdir, NULL); | ||
| } | ||
|
|
||
| void Mecab_print_load_error(const char *dicdir, const char *userdic) { |
There was a problem hiding this comment.
今言うのは微妙ですが、ここはstatic voidにしてMecab_というprefixを外した方がよかった気がします。
There was a problem hiding this comment.
たしかに。private関数だからMecab_いらなかった。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Mecab_load_with_userdicを追加します。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）