Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC 14.37の仕様変更への対応 #19

Merged
merged 1 commit into from
Sep 8, 2023
Merged

MSVC 14.37の仕様変更への対応 #19

merged 1 commit into from
Sep 8, 2023

Conversation

My-MC
Copy link

@My-MC My-MC commented Sep 8, 2023 •
edited
Loading

内容

VOICEVOX/open_jtalk#11 の続きです。
open_jtalkのリポジトリのコミットIDを更新します。

MSVC14.37でビルドができ、テストを通過することができました。

関連 Issue

ref VOICEVOX/open_jtalk#10
ref VOICEVOX/open_jtalk#11

スクリーンショット・動画など

その他

y-chan
y-chan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

Hiroshiba
Hiroshiba approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

おっと、なんかテスト落ちてますね･･･。
pysenのpython3.7のなにかが変わったから･･･？
本家pyopenjtalkマージしたら変わったりしないかな、ちょっとマージ後に試してみようと思います！

@Hiroshiba Hiroshiba merged commit ba5a316 into VOICEVOX:master Sep 8, 2023
3 of 6 checks passed
@Hiroshiba Hiroshiba mentioned this pull request Sep 8, 2023
Merged
@My-MC My-MC mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@My-MC @Hiroshiba @y-chan