project-s: テンポ・拍子の表示と設定を行う機能を追加 #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
positionの値がチェックできてないので修正します…！ |
romot-co
reviewed
Nov 21, 2022
romot-co
approved these changes
Nov 22, 2022
Hiroshiba
reviewed
Nov 24, 2022
|
レビューありがとうございました！！ |
sigprogramming
deleted the
feature/ui_to_set_tempo_and_time_signature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
テンポ・拍子の表示と設定を行う機能を追加します。
action/mutationとリアクティブ周りの実装が不安なので、ご指摘等いただけますと幸いです。
レビューよろしくお願いいたします。
関連 Issue
ref VOICEVOX/voicevox_project#15
ref #981
その他
UIのデザインは仮なので、また後で調整できればと思います。