Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] mac版のログ保存ディレクトリの案内が間違っていたので訂正する #1455

Merged

Conversation

Hiroshiba
Copy link
Member

内容

タイトルの通りです。こちらのissueの解決です。

関連 Issue

fix #1452

その他

electronが使うパスでビルド時のアプリの名称(voicevox-cpu)が入りそうなところはlogsとuserDataくらいっぽいです。なのでエラーログの案内さえ変えればとりあえず解決かなと。
https://www.electronjs.org/ja/docs/latest/api/app#appgetpathname

それはそれとして、CPU版とGPU版で変えているアプリ名称の影響を抑えたいので、background.ts内でsetAppNameしちゃうのも良いかなと思いました。
issueを作ってみようと思います。

@Hiroshiba Hiroshiba requested a review from a team as a code owner August 2, 2023 05:50
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team August 2, 2023 05:51
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 87cfc8a into main Aug 3, 2023
14 checks passed
@Hiroshiba Hiroshiba deleted the mac版のログのディレクトリが違うので案内 branch August 3, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mac版にlogsディレクトリが無い
2 participants