-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ドキュメントを刷新する #532
ドキュメントを刷新する #532
Changes from 26 commits
fb19061
43fab14
e75f8af
2a480c7
806597d
7637da5
a066ea5
a4c895d
f71379c
9b1cbde
246f05f
5ae4d09
8c0e803
67e3325
b617250
9bbb11d
020561e
23733cb
804542f
e37367b
f1da372
353c8e2
d79ed0d
2e1f154
887b31c
f9a1869
03c8df0
b4dbc8d
f8d5758
27d067b
271bbaa
2355d30
941bc65
bc0f5a2
5bf35f4
b33bcb5
a35750b
f8b8c9d
2509a6a
9d4432e
e532d7c
d391031
252bcc5
67e2507
79d96fe
570d782
e45db25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ pub enum OpenJtalkError { | |
|
||
pub type Result<T> = std::result::Result<T, OpenJtalkError>; | ||
|
||
/// テキスト解析器としてのOpen JTalk。 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. VOICEVOXにおけるOpen JTalkの役割を明記。 |
||
pub struct OpenJtalk { | ||
resources: Mutex<Resources>, | ||
dict_loaded: bool, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,11 +5,7 @@ use super::*; | |
use std::path::PathBuf; | ||
use thiserror::Error; | ||
|
||
/* | ||
* 新しいエラーを定義したら、必ずresult_code.rsにあるVoicevoxResultCodeに対応するコードを定義し、 | ||
* internal.rsにある変換関数に変換処理を加えること | ||
*/ | ||
|
||
Comment on lines
-9
to
-13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 今となっては嘘コメントとなってしまっているため、削除。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mainの方に「嘘コメント一掃」みたいなPRをだしてもいいのかも。 |
||
/// VOICEVOX COREのエラー。 | ||
#[derive(Error, Debug)] | ||
pub enum Error { | ||
/* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//! 無料で使える中品質なテキスト読み上げソフトウェア、VOICEVOXのコア。 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. このリポジトリのdescriptionをそのまま。 |
||
|
||
#![deny(unsafe_code)] | ||
|
||
mod devices; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,17 @@ use super::*; | |
use derive_getters::Getters; | ||
use serde::{Deserialize, Serialize}; | ||
|
||
/// スタイルIdの実体 | ||
/// [`StyleId`]の実体。 | ||
/// | ||
/// [`StyleId`]: StyleId | ||
pub type RawStyleId = u32; | ||
/// スタイルId | ||
|
||
/// スタイルID。 | ||
/// | ||
/// VOICEVOXにおける、ある[**話者**(_speaker_)]のある[**スタイル**(_style_)]を指す。 | ||
/// | ||
/// [**話者**(_speaker_)]: SpeakerMeta | ||
/// [**スタイル**(_style_)]: StyleMeta | ||
Comment on lines
+12
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. APIとしては「声」("voice")を指し示すのにスタイルを指定しているため、これは明記しておかないと混乱をまねくかと思い、こう記述。 |
||
#[derive(PartialEq, Eq, Clone, Copy, Ord, PartialOrd, Deserialize, Serialize, new, Debug)] | ||
pub struct StyleId(RawStyleId); | ||
|
||
|
@@ -22,8 +30,12 @@ impl Display for StyleId { | |
} | ||
} | ||
|
||
/// [`StyleVersion`]の実体。 | ||
/// | ||
/// [`StyleVersion`]: StyleVersion | ||
pub type RawStyleVersion = String; | ||
|
||
/// スタイルのバージョン。 | ||
#[derive(PartialEq, Eq, Clone, Ord, PartialOrd, Deserialize, Serialize, new, Debug)] | ||
pub struct StyleVersion(RawStyleVersion); | ||
|
||
|
@@ -39,21 +51,27 @@ impl Display for StyleVersion { | |
} | ||
} | ||
|
||
/// 音声モデルのメタ情報 | ||
/// 音声モデルのメタ情報。 | ||
pub type VoiceModelMeta = Vec<SpeakerMeta>; | ||
|
||
/// スピーカーのメタ情報 | ||
/// **話者**(_speaker_)のメタ情報。 | ||
#[derive(Deserialize, Serialize, Getters, Clone)] | ||
pub struct SpeakerMeta { | ||
/// 話者名。 | ||
name: String, | ||
/// 話者に属するスタイル。 | ||
styles: Vec<StyleMeta>, | ||
/// 話者のバージョン。 | ||
version: StyleVersion, | ||
/// 話者のUUID。 | ||
speaker_uuid: String, | ||
} | ||
|
||
/// スタイルのメタ情報 | ||
/// **スタイル**(_style_)のメタ情報。 | ||
#[derive(Deserialize, Serialize, Getters, Clone)] | ||
pub struct StyleMeta { | ||
/// スタイルID。 | ||
id: StyleId, | ||
/// スタイル名。 | ||
name: String, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AudioQueryがドメイン用語として運用してもよかった記憶があったのでAccentPhraseもそうしたが、こっちは「アクセント句」のままでもよかったかも。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
エンジンだとAudioQueryは「クエリ」、AccentPhraseは「アクセント句」にしてました。
ちょっとわかりづらそうだなと思ったらこっち側で改修しようと思います。(たぶんそのままで行くと思います。)