[project-vvm-async-api] Fix up #534 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Jul 1, 2023
Comment on lines
+33
to
+36
| /// - `out_ptr`は書き込みについて[有効]でなければならない。 | ||
| /// - `out_len`は書き込みについて[有効]でなければならない。 | ||
| /// | ||
| /// [有効]: https://doc.rust-lang.org/stable/std/ptr/index.html#safety |
There was a problem hiding this comment.
ついでにここも更新。
「書き込みについて有効」という言い方も微妙かもしれませんが、write_unalignedのsafetyがこうなっており、またこの言い回しについての日本語訳の先例が見当たらなかったので、これをそのまま訳す形にしました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#534 で、
write_unalignedを間違えてwrite_volatileにしていた箇所があったので修正します。(補完に出たのをそのまま打ってしまいました)
関連 Issue
output_系引数がunalignedであることを許す #534その他