Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js向けのFFIを実装 #758
base: main
Are you sure you want to change the base?
Node.js向けのFFIを実装 #758
Changes from all commits
a12e6d2
7f871a3
ea809fb
a507b62
a3584d3
c418030
cd04f47
8a2462f
58ef4bb
04eee9a
2386695
e1fe417
bc6360f
cfd1c71
020e0dd
4dd1052
17a572f
e8e16dd
de13bf5
0f10872
c3eac14
b4e1251
3a63e2a
eda6086
8c7203f
0988e9f
dac865a
230da3e
1abc435
023a5d3
e98b733
4eef4f1
0b7890f
c9445e3
156dfb1
4906eac
ed215a7
427661d
a2a2251
15e7cbe
c5c52ea
950a7b3
7d45fda
d6fcae9
14e6e3d
55e6e00
6d6e619
48f3bb6
8ffbc91
72af516
046618b
e04da34
d97ecc7
aaefb43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#802 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テスト前に
cargo build -p test_util
が要るんじゃないかと思います。(クリーンなリポジトリからvoicevox_core_node_apiだけビルドした場合、crates/test_util/dataは生成されない)
参考:
voicevox_core/.github/workflows/test.yml
Line 279 in 18aec9f
voicevox_core/.github/workflows/test.yml
Line 315 in 18aec9f
npm test
内に仕込むのがいいかもしれませんが、どうやるかは私にはよくわからないです。なんかnpm-run-all2っていう、かつてのnpm-run-allのフォークがあるっぽい…?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm-run-all2使うとこんな感じだと思います。
まぁ直列ならOS差は困るほどはないので、
でいいかも。avaにセットアップのHookがあるならそれでビルドしてもいいかも?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#791 (comment)