Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rust 1.79と1.80で追加された機能を利用する #816

Merged
merged 5 commits into from
Aug 11, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Aug 10, 2024

内容

#771 ぶりに、Rust 1.79およびRust 1.80に追加された機能を使うリファクタを行います。

もっと遡るのも考えたのですが、沼りそうだし飽きたので1.79までに留めました。

関連 Issue

その他

各変更は別個のコミットにまとめます。draftを外すまで、force pushをしてブランチを破壊します。

[追記1] 結局force pushはしませんでした…
[追記2] しました

@qryxip qryxip marked this pull request as draft August 10, 2024 15:10
@qryxip qryxip changed the title chore: Rust 1.80で追加された機能を利用する chore: Rust 1.79と1.80で追加された機能を利用する Aug 11, 2024
@qryxip qryxip force-pushed the chore-use-features-of-rust-1-80 branch from dacc120 to 3da1871 Compare August 11, 2024 15:27
@qryxip qryxip marked this pull request as ready for review August 11, 2024 15:33
@qryxip qryxip requested a review from Hiroshiba August 11, 2024 15:33
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit 1e75e4e into VOICEVOX:main Aug 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants