Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java)!: com.microsoft.onnxruntime/onnxruntime{,_gpu}を削除 #860

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 21, 2024

内容

#802 により不要になり、また #825 の支障になるであろうJavaのonnxruntime{,_gpu}パッケージを削除する。

またそれに伴い、artifactIdをEPごとにリネームするのをやめる。

関連 Issue

Refs: #802, #764, #858

その他

Cc: @sevenc-nanashi

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大丈夫だと思います。

@qryxip qryxip requested a review from Hiroshiba October 21, 2024 07:43
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qryxip qryxip merged commit 23c2a62 into VOICEVOX:main Oct 23, 2024
30 checks passed
@qryxip qryxip deleted the feat-java-rm-com-microsoft-onnxruntime-onnxruntime branch October 23, 2024 16:25
@qryxip
Copy link
Member Author

qryxip commented Oct 23, 2024

あ、これ消し忘れた。どうしよう…

onnxruntimeVersion = '1.17.3'

@Hiroshiba
Copy link
Member

よくわかってないんですけど、消すPRを新しく作る感じで良さそうな気もしました!
↓にこそっと追加でもいいのかも。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants