Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: content-hash 未更新予防 #1091

Closed
3 tasks done
tarepan opened this issue Feb 28, 2024 · 1 comment · Fixed by #1099
Closed
3 tasks done

add: content-hash 未更新予防 #1091

tarepan opened this issue Feb 28, 2024 · 1 comment · Fixed by #1099
Labels
機能向上

Comments

@tarepan
Copy link
Contributor

tarepan commented Feb 28, 2024

内容

要望概要: content-hash 未更新を pre-commit で予防したい

参考: #1081

Pros 良くなる点

  • 不完全な commit の予防によるレビュー負荷の低減

Cons 悪くなる点

無し

実現方法

検討中

VOICEVOXのバージョン

0.16.0

OSの種類/ディストリ/バージョン

  • Windows
  • macOS
  • Linux

その他
@github-actions github-actions bot added OS 依存：linux Linux に依存した現象 OS 依存：mac macOS に依存した現象 OS 依存：win Windows に依存した現象 labels Feb 28, 2024
@tarepan tarepan mentioned this issue Feb 28, 2024
Merged
@Hiroshiba
Copy link
Member

こちらにも同じコメントを･･･！ #1090 (comment)

pre-comitに追加、ありだと思います！

ちなみに昔poetry exportを同じくpre commitで実装した際のプルリクエストがこちらです。（ thx. @FujisakiEx ！）

This was referenced Feb 29, 2024
Closed
Merged
@tarepan tarepan added the 状態：実装 実装をおこなっている状態 label Mar 5, 2024
@tarepan tarepan mentioned this issue Mar 5, 2024
Open
@tarepan tarepan removed OS 依存：mac macOS に依存した現象 OS 依存：linux Linux に依存した現象 OS 依存：win Windows に依存した現象 labels Mar 8, 2024
@tarepan tarepan removed the 状態：実装 実装をおこなっている状態 label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
機能向上
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

追加: poetry check フック tarepan/voicevox_engine
2 participants
@Hiroshiba @tarepan