MAINT: パッケージ更新 #1466
Merged
MAINT: パッケージ更新 #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabonerune
commented
Aug 30, 2024
Comment on lines
+66
to
+67
| "le": None, | ||
| "ge": None, |
There was a problem hiding this comment.
何故かOpenAPIスキーマーに
"le": 0,
"ge": 10,
が新しく追加されてしまったのでそれを回避するための修正です。
ただ存在しても動作自体に影響はないからこの修正はなくてもいいかも…
これもSkipJsonSchema[None]の副作用のようです。
There was a problem hiding this comment.
うーーーーーんなるほどです！
この辺りもしちょっとよければ掃除してあげたいですね！！（別プルリクエストで）
ちょっと面倒かもなのですが、なんかいい感じにしていただけるとすごく助かります！！
この辺り詳しいの僕たちくらいなので。。。。。もしモチベあれば。。。
わかんないとこあったら何でも聞いていただければ （まあ僕もわからないのですが 😇 ）
| try: | ||
| uvicorn.run(app, host=args.host, port=args.port) | ||
| except KeyboardInterrupt: | ||
| print("`KeyboardInterrupt` の検出によりエンジンを停止しました。") | ||
| pass | ||
| uvicorn.run(app, host=args.host, port=args.port) |
There was a problem hiding this comment.
KeyboardInterruptが抑制されるようになったため削除。
https://www.uvicorn.org/release-notes/#0303-2024-07-20
Hiroshiba
reviewed
Sep 3, 2024
Hiroshiba
reviewed
Sep 3, 2024
|
starletteとpip-licensesを修正しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
依存パッケージの更新を行います。
関連 Issue
その他
^5.0.0に変更しました。これによりメジャーバージョンが5に固定されます。