Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Dec 16, 2023
Comment on lines
+870
to
+872
| if engine_manifest_data.supported_features.manage_library: | ||
|
|
||
| @app.post( | ||
| "/install_library/{library_uuid}", | ||
| status_code=204, | ||
| tags=["音声ライブラリ管理"], | ||
| ) | ||
| async def install_library( | ||
| library_uuid: str, | ||
| request: Request, | ||
| ) -> Response: | ||
| """ | ||
| 音声ライブラリをインストールします。 | ||
| 音声ライブラリのZIPファイルをリクエストボディとして送信してください。 | ||
|
|
||
| Parameters | ||
| ---------- | ||
| library_uuid: str | ||
| 音声ライブラリのID | ||
| """ | ||
| if not engine_manifest_data.supported_features.manage_library: | ||
| raise HTTPException(status_code=404, detail="この機能は実装されていません") | ||
| archive = BytesIO(await request.body()) | ||
| loop = asyncio.get_event_loop() | ||
| await loop.run_in_executor( | ||
| None, library_manager.install_library, library_uuid, archive | ||
| @app.get( |
There was a problem hiding this comment.
ちなみにここの空行はフォーマッターが入れてきました。
Coverage ResultResultを開く
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
エンジン0.15にアップデートする予定です。
製品版にはまだライブラリ管理機能がないので、APIが実装されていると、叩けるのかと勘違いして色々試される方が出てきそうに思いました。
であればいっそう未実装な方が良いので、マニフェストの値を見てAPI自体をなくすようにしてみました。
関連 Issue
その他
他のアイデアとして、マニフェスト的に対応していなかった場合に、APIは叩けるけれどもエラーが返る実装も考えました。
でもまあその場合はドキュメントでも未実装であることが案内できると良さそうで、なんかややこしそうだったので一旦簡単な方で実装してみました。