MAINT: 未使用の依存パッケージを削除 #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ResultResultを開く
|
sabonerune
commented
Dec 31, 2023
Comment on lines
-66
to
-67
| atomicwrites = "^1.4.0" | ||
| colorama = "^0.4.4" |
There was a problem hiding this comment.
ref: #219 (comment)
WSL上で作業したところcoloramaがWindowsのみインストールされるようにrequirements*.txtが構成されていたため削除しても問題ないと思います。
(atomicwritesは使用するパッケージが無くなったため削除)
| soundfile = "^0.12.1" | ||
| pyyaml = "^6.0" | ||
| pyworld = "^0.3.0" | ||
| requests = "^2.28.1" |
| @@ -48,23 +48,18 @@ numpy = "^1.20.0" | |||
| fastapi = "^0.103.2" | |||
| python-multipart = "^0.0.5" | |||
| uvicorn = "^0.15.0" | |||
| aiofiles = "^0.7.0" | |||
There was a problem hiding this comment.
不明
初期から入っているが使用している様子がないため削除
There was a problem hiding this comment.
これなんであるのかわからないですね･･･。ビルドに含めてたことがあったっぽい･･･？
Line 84 in fcb38c0
| jinja2 = "^3.1.2" | ||
| pyopenjtalk = { git = "https://github.com/VOICEVOX/pyopenjtalk", rev = "b35fc89fe42948a28e33aed886ea145a51113f88" } | ||
| semver = "^3.0.0" | ||
| platformdirs = "^3.10.0" | ||
| soxr = "^0.3.6" | ||
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| cython = "^0.29.34,>=0.29.33" # NOTE: for Python 3.11 |
There was a problem hiding this comment.
不要のはず。
(pyworldが何故かinstall_requires内で宣言しているため完全に削除不能)
Hiroshiba
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
pyploject.tomlに記載されているが現在使用されていないパッケージを削除します。