Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind of dish (meat/fish/vegetarian/vegan) #283

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

mhvis
Copy link
Member

@mhvis mhvis commented Jan 13, 2024

I added a 'kind of dish' field. What do you think @Ndoll1? If you have ideas for additional kinds or other fields lmk (maybe lactose-free/gluten/..). Thanks for creating #266.

Overview:
image

Dining list page:
image

Choices:
image

Closes #266

@mhvis mhvis added the enhancement New feature or request label Jan 13, 2024
@mhvis mhvis self-assigned this Jan 13, 2024
@Ndoll1
Copy link
Collaborator

Ndoll1 commented Jan 13, 2024

Looks great.

In the EU there is a list of allergens that need to be specified in restaurants and need to be bold on packages.

image

If you want to add something else look into those. Maybe as allergensoverview for the cooks with English and Dutch names of what they need to check for.

@mhvis
Copy link
Member Author

mhvis commented Jan 13, 2024

I was thinking about something like that indeed. But it might be quite a lot of work for the cook to specify all nutrients. And there's a risk of errors. So it's probably better to have people with (difficult) allergies write a comment.

@Ndoll1
Copy link
Collaborator

Ndoll1 commented Jan 13, 2024

That is true. I meant it in a way that anyone can preselect these allergens as I have that allergy. And then other as comment. (Personal information)

The cook can then get on overview of all allergens. Is easier to check in my opinion. Also since it is a preselect you can provide the info in multiple languages. Because the packages not always contains English info, but Dutch they do.

So you have those 14. Only shown when someone noted that they have that allergen. And then other which is always shown.

@mhvis
Copy link
Member Author

mhvis commented Jan 13, 2024

Oh yeah that is smart. I was thinking the other way around, but it's indeed much better to just improve the allergens field in the personal account information to have a selection of choices.

@Ndoll1
Copy link
Collaborator

Ndoll1 commented Jan 13, 2024

Yep. But keep in mind that other is really important then as well. These 14 do not contain all allergens.

I also would advise to separate allergies and wishes then.

@mhvis mhvis mentioned this pull request Jan 13, 2024
@mhvis mhvis merged commit d64b485 into master Jan 17, 2024
1 check passed
@mhvis mhvis deleted the mhvis/202401/dishkind branch January 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meat, vegetarian, vegan icon visible to indicate what kind of dish is prepared
2 participants