-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sim_if/modelsim: use vmap to find modelsim.ini #975
base: master
Are you sure you want to change the base?
Conversation
250d9c2
to
62d5fb4
Compare
@LarsAsplund: Friendly ping? |
@bjornfor Sounds like a good idea but there is a problem that needs to be solved. Removing the constraint from the |
62d5fb4
to
a2e423d
Compare
I pushed a new version, and fixed the unit tests, which I didn't realize this PR was breaking 😅 I don't have a way to test |
a2e423d
to
8ea9c7d
Compare
* This creates a single source of truth for finding modelsim.ini. It is now possible to use MODELSIM=/path/to/custom/modelsim.ini and both ModelSim and vunit will use that. (The VUNIT_MODELSIM_INI environment variable can still be used to override modelsim.ini only for vunit.) * This fixes detecting modelsim.ini in the quartus-prime-lite package from https://github.com/nixos/nixpkgs, which exposes binaries at $prefix/bin, but has no $prefix/modelsim.ini, because the latter would be an FHS violation.
8ea9c7d
to
587a620
Compare
I think I've fixed the linter issues now. |
Friendly ping. |
now possible to use MODELSIM=/path/to/custom/modelsim.ini and both
ModelSim and vunit will use that. (The VUNIT_MODELSIM_INI environment
variable can still be used to override modelsim.ini only for vunit.)
from https://github.com/nixos/nixpkgs, which exposes binaries at
$prefix/bin, but has no $prefix/modelsim.ini, because the latter would
be an FHS violation.