Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Toast Notification to the whole webapp Successfully Issue 103 #107

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jun 4, 2024

Pull Request Resolves [#103 ]

Title: Added Toast Notification to the whole webapp

Description

  1. Used react-hot-toast npm library throughout the app.
  2. First is init in App.tsx.
  3. With toast.success/error the operation is performed.

Related Issues

Fixes: #103

Changes Made

New feature: Added Toast Notification with react-hot-toast.

Screenshots

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 5:53pm

Copy link

github-actions bot commented Jun 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@VaibhavArora314
Copy link
Owner

did you also push changes of the like/dislike functionality of your other PR

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

No, i created two branch for both the issues #103 and #87 i don't know why it is showing commit's above ?

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

Ya i think the above pr ha both the functinality toast + like/dislike .

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

You can merge it without conflicts

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve merge conflicts

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

@VaibhavArora314 Done 👍

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good, just one thing in the Profile, don't remove error message and verification error state logic

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

@VaibhavArora314 finally it's done :)

@VaibhavArora314 VaibhavArora314 merged commit 4508d92 into VaibhavArora314:main Jun 4, 2024
3 checks passed
Copy link

github-actions bot commented Jun 4, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding Toast Notification to the whole webapp.
2 participants