Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a 404 page not found route in frontend Successfully Issue 105 #111

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jun 4, 2024

Pull Request Resolves [#105 ]

Title: Added a 404 page not found route in frontend.

Description

  1. Added Image in assests of size ~ 300kb.
  2. Added Route and text in NotFoundPage file.

Related Issues

Fixes: #105

Changes Made

New feature: Added a 404 page not found route in frontend.

Screenshots

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 6:11pm

Copy link

github-actions bot commented Jun 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, resolve merge conflicts and did u push toast commits in this?

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

@VaibhavArora314 it's Done :), and also it has toast feature also.

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is great for not found route page, just that the error/verification error state logic has to be added back in Profile (part of toast pr)

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

okay, got it

@VaibhavArora314
Copy link
Owner

@MeetDOD resolve merge conflicts rest is good.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

😭

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 4, 2024

@VaibhavArora314 have a look !

@VaibhavArora314 VaibhavArora314 merged commit 1bd3846 into VaibhavArora314:main Jun 4, 2024
3 checks passed
Copy link

github-actions bot commented Jun 4, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding a 404 page not found route in frontend.
2 participants