-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added mark components as favorites and unfavorites feature successfully issue 123 #125
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@VaibhavArora314 Tell me other features you like to see in future >_< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- in getFavoritePostsController, get userId from UserAuthRequest instead of params
- there is no need to send a me request separately in the Favorite.tsx, The userState is already present in store/atoms
…erState from atoms age instead of fetching /me api
@VaibhavArora314 Done the changes as requested ! |
also @VaibhavArora314 assign me issue #126 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove /:id from the route to get favorite posts
I have asked the assigned person, if he is inactive or not working on it anymore then you can work on it |
then how i will able to fetch their fav posts ? |
@VaibhavArora314 sir, I checked and tested the whole feature and it's working fine ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will later separate the routes to avoid conflicts.
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Pull Request Resolves [#123 ]
Title: Added mark components as favorites and unfavorites feature.
Description
Related Issues
Fixes #123
Changes Made
New features: Adding mark components as favorites/unfavorities.
Screenshots
Video Demo
Style.Share.-.Google.Chrome.2024-06-06.15-06-08.1.online-video-cutter.mp4
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.