Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug of pages rendering at bottom #151

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

pani2004
Copy link
Contributor

@pani2004 pani2004 commented Jun 8, 2024

Fixed the bug of pages rendering at bottom

Solved issue #141

  • [ x] I have tested the changes locally
  • [ x] Changes are backward-compatible
www_screencapture_com_2024-6-8_20_14.mp4

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 7:06am

Copy link

github-actions bot commented Jun 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@pani2004
Copy link
Contributor Author

pani2004 commented Jun 8, 2024

@VaibhavArora314 Pls review the PR!!!!

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, just rename that component as ScrollToTopWhenRouteChanges because we also have a scroll to top button and it can be confused with it currently

@pani2004
Copy link
Contributor Author

pani2004 commented Jun 9, 2024

@VaibhavArora314 Made the changes

@VaibhavArora314 VaibhavArora314 merged commit fd7b5f9 into VaibhavArora314:main Jun 9, 2024
2 checks passed
Copy link

github-actions bot commented Jun 9, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants