Skip to content

feat: Added Multilanguage feature in overall webapp successfully issue 149 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jun 10, 2024

Pull Request Resolves[#149 ]

Title: Added Multilanguage feature in overall webapp successfully.

Description

  1. With the help of npm packages => i18next and react-i18next, I implemented this feature.
  2. In this I created a i18n where all the init and language function is coded and imported in app.tsx.
  3. Then i create a navbar so user can choose between the various languagues, initially i implemented total top 7 Indian languages.
  4. I am storing the lan in localStorage also so that even when reload the page it remain as it is.
  5. All I fixed the dropdown so that it will appear in all the pages.
  6. I am not implementing it in the toast messages because they are comming from the backend and all.
  7. I had try to convert as many text as possible to different languages.

Related Issues

Fixes #149

Changes Made

New features: Added Multilanguage feature in overall webapp.

Screenshots

image

Video

NOTE: There is a problem in the video the dropdown is not showing. so, I added it in screenshots

Style.Share.-.Google.Chrome.2024-06-11.00-22-31.online-video-cutter.com.1.mp4

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 8:54am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 10, 2024

@VaibhavArora314 what you think about this feature 🤔, is it worth for level 3 ? It's a unique approach that's why. I think that hardly web app have this feature under gssoc ! And thank you :)

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 10, 2024

@VaibhavArora314 If you want more languages that just give me the names i will implement them.

@VaibhavArora314
Copy link
Owner

@VaibhavArora314 If you want more languages that just give me the names i will implement them.

this much looks good, I will take some time to review it completely since there are so many changes

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 11, 2024

Ya, the languages is coming from locales => en,hi,... => translation.json. aslo, should i resolve the conflicts ?

@VaibhavArora314
Copy link
Owner

Ya, the languages is coming from locales => en,hi,... => translation.json. aslo, should i resolve the conflicts ?

yes, resolve the conflicts

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 11, 2024

Done @VaibhavArora314 also tell me if you want more languages 😄

@VaibhavArora314 VaibhavArora314 merged commit e654980 into VaibhavArora314:main Jun 11, 2024
3 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Muti Language support
2 participants