-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OTP verification for signup #32
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
this looks good but since there are so many changes, I will take some time to review it |
Sure, pls take your time. |
Hey so upon closer inspection I found that we are sending the jwt token on the user sign-up route and updating it in the recoil state after verifying the user but this has a security loophole as the user can inspect the frontend application and get the jwt token without verifying the email id and use it further. So I suggest that we should send the jwt token in the verify route itself and not in the sign-up route in the backend. |
Alright. I'll make that change. |
For this to work, you need to have -
Also pls the the GSSoC and Level 3 labels. |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
What does it fix?
Fixes #9 . When signing up users get a OTP which they need to enter for verification.
What features does it add?
Screen recording for normal sign up flow:
Style.Share.-.Google.Chrome.2024-05-29.19-45-50.mp4