Feat: Fixed Search Bar feature with search button successfully Issue 362 #369

MeetDOD · 2024-07-04T06:59:41Z

Pull Request Resolve [#362 ]

Title: Fixed Search Bar feature with search button successfully.

Description

So, instead of calling API again and again i created a button for search so that the api hit doesn't happen when writing each alphabet by user.
It will search only when the user click on the search button.
It will reduce the load on the backend.
The Search/button is responsive and work in light/dark mode.

Related Issues

Fixes #362

Changes Made

New features: Fixed Search Bar feature with search button.

Screenshots

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

vercel · 2024-07-04T06:59:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
style-share	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 6, 2024 7:38am

github-actions · 2024-07-04T06:59:51Z

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

VaibhavArora314

overall looking, just don't push changes of your other pr

VaibhavArora314 · 2024-07-04T13:25:13Z

frontend/src/App.tsx

comment these lines

MeetDOD · 2024-07-04T13:43:20Z

overall looking, just don't push changes of your other pr

Sorry It want happen again 🙏

MeetDOD · 2024-07-04T16:46:00Z

@akbatra567 @Ultimateutkarsh11 Please review this pr, if any issue let me know 😄

akbatra567

I see there are some other changed in the PR, regarding adding captcha.

Could you remove them from this PR?

MeetDOD · 2024-07-05T08:33:06Z

I see there are some other changed in the PR, regarding adding captcha.

Could you remove them from this PR?

You merge the captcha PR and i will resolve the merge conflicts here

akbatra567 · 2024-07-05T08:55:40Z

I see there are some other changed in the PR, regarding adding captcha.

Could you remove them from this PR?

You merge the captcha PR and i will resolve the merge conflicts here

PRs should be independent of one another, you can create multiple branches to divide code for each issue. If the other PR is not approved and this gets approved. It's not a good practice to have unrelated code and unapproved changes from the other PR might go unreviewed.

MeetDOD · 2024-07-05T09:05:35Z

@akbatra567 approve/review my other PR i will fix this one now only !

…ue-362

MeetDOD · 2024-07-05T14:10:09Z

Done

MeetDOD · 2024-07-06T04:27:06Z

@akbatra567 please review this PR 🙏 @Ultimateutkarsh11

akbatra567 · 2024-07-06T04:34:59Z

frontend/src/pages/Signin.tsx

+    if (!isCaptchaValid) {
+      toast.error('Captcha is not valid');
+      return;
+    }
+


Remove this duplicate code

Done @akbatra567

frontend/src/pages/Posts.tsx

VaibhavArora314 · 2024-07-06T06:55:11Z

frontend/src/pages/Signin.tsx

            <p className="text-sm font-semibold mb-2 text-red-600">
              {error.password}
            </p>
            <CaptchaUser onChange={(isValid) => setIsCaptchaValid(isValid)} /> {/* Add Captcha component */}
          </div>
+          <CaptchaUser onChange={(isValid) => setIsCaptchaValid(isValid)} />


remove captcha from here since already present

Done @VaibhavArora314

MeetDOD · 2024-07-06T07:43:39Z

@Ultimateutkarsh11 Please review this pr if changes exists let me know :)

MeetDOD · 2024-07-06T20:00:37Z

@akbatra567 Thanks and also check this also 👍

MeetDOD · 2024-07-07T05:15:07Z

@VaibhavArora314 merge this pr and have a look at pr #385

github-actions · 2024-07-07T09:34:07Z

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

MeetDOD added 3 commits July 3, 2024 19:05

Adding captcha

f15e1ad

Merge branch 'main' of https://github.com/MeetDOD/StyleShare

6f5e7e1

Fixed the search bar

e06a628

vercel bot deployed to Preview July 4, 2024 07:01 View deployment

VaibhavArora314 reviewed Jul 4, 2024

View reviewed changes

frontend/src/App.tsx Outdated

Copy link

Owner

VaibhavArora314 Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment these lines

MeetDOD reacted with thumbs up emoji

VaibhavArora314 requested review from akbatra567 and Ultimateutkarsh11 July 4, 2024 13:25

Removed the default url

56ccecd

vercel bot deployed to Preview July 4, 2024 13:59 View deployment

akbatra567 requested changes Jul 5, 2024

View reviewed changes

Merge branch 'main' of https://github.com/MeetDOD/StyleShare into iss…

2faf5d6

…ue-362

vercel bot deployed to Preview July 5, 2024 14:11 View deployment

akbatra567 reviewed Jul 6, 2024

View reviewed changes

Removed duplicate code

7d38e85

vercel bot deployed to Preview July 6, 2024 04:55 View deployment

VaibhavArora314 requested changes Jul 6, 2024

View reviewed changes

Fixed signin page bugs

10b358c

vercel bot deployed to Preview July 6, 2024 07:38 View deployment

VaibhavArora314 approved these changes Jul 6, 2024

View reviewed changes

Ultimateutkarsh11 approved these changes Jul 6, 2024

View reviewed changes

akbatra567 approved these changes Jul 6, 2024

View reviewed changes

VaibhavArora314 merged commit 10a7e38 into VaibhavArora314:main Jul 7, 2024
3 checks passed

VaibhavArora314 assigned MeetDOD Jul 7, 2024

VaibhavArora314 added gssoc GSSOC level2 labels Jul 7, 2024

Feat: Fixed Search Bar feature with search button successfully Issue 362 #369

Feat: Fixed Search Bar feature with search button successfully Issue 362 #369

Uh oh!

Conversation

MeetDOD commented Jul 4, 2024

Pull Request Resolve [#362 ]

Title: Fixed Search Bar feature with search button successfully.

Description

Related Issues

Changes Made

Screenshots

Uh oh!

vercel bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2024

Uh oh!

VaibhavArora314 left a comment

Choose a reason for hiding this comment

Uh oh!

VaibhavArora314 Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

MeetDOD commented Jul 4, 2024

Uh oh!

MeetDOD commented Jul 4, 2024

Uh oh!

akbatra567 left a comment

Choose a reason for hiding this comment

Uh oh!

MeetDOD commented Jul 5, 2024

Uh oh!

akbatra567 commented Jul 5, 2024

Uh oh!

MeetDOD commented Jul 5, 2024

Uh oh!

MeetDOD commented Jul 5, 2024

Uh oh!

MeetDOD commented Jul 6, 2024

Uh oh!

akbatra567 Jul 6, 2024

Choose a reason for hiding this comment

Uh oh!

MeetDOD Jul 6, 2024

Choose a reason for hiding this comment

Uh oh!

MeetDOD Jul 6, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VaibhavArora314 Jul 6, 2024

Choose a reason for hiding this comment

Uh oh!

MeetDOD Jul 6, 2024

Choose a reason for hiding this comment

Uh oh!

MeetDOD commented Jul 6, 2024

Uh oh!

MeetDOD commented Jul 6, 2024

Uh oh!

MeetDOD commented Jul 7, 2024

Uh oh!

Uh oh!

github-actions bot commented Jul 7, 2024

Uh oh!

Uh oh!

vercel bot commented Jul 4, 2024 •

edited

Loading