Skip to content

Feat: Fixed Search Bar feature with search button successfully Issue 362 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 4, 2024

Pull Request Resolve [#362 ]

Title: Fixed Search Bar feature with search button successfully.

Description

  1. So, instead of calling API again and again i created a button for search so that the api hit doesn't happen when writing each alphabet by user.
  2. It will search only when the user click on the search button.
  3. It will reduce the load on the backend.
  4. The Search/button is responsive and work in light/dark mode.

Related Issues

Fixes #362

Changes Made

New features: Fixed Search Bar feature with search button.

Screenshots

image

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 7:38am

Copy link

github-actions bot commented Jul 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking, just don't push changes of your other pr

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment these lines

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 4, 2024

overall looking, just don't push changes of your other pr

Sorry It want happen again 🙏

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 4, 2024

@akbatra567 @Ultimateutkarsh11 Please review this pr, if any issue let me know 😄

Copy link
Collaborator

@akbatra567 akbatra567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are some other changed in the PR, regarding adding captcha.

Could you remove them from this PR?

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 5, 2024

I see there are some other changed in the PR, regarding adding captcha.

Could you remove them from this PR?

You merge the captcha PR and i will resolve the merge conflicts here

@akbatra567
Copy link
Collaborator

I see there are some other changed in the PR, regarding adding captcha.

Could you remove them from this PR?

You merge the captcha PR and i will resolve the merge conflicts here

PRs should be independent of one another, you can create multiple branches to divide code for each issue. If the other PR is not approved and this gets approved. It's not a good practice to have unrelated code and unapproved changes from the other PR might go unreviewed.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 5, 2024

@akbatra567 approve/review my other PR i will fix this one now only !

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 5, 2024

Done

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 6, 2024

@akbatra567 please review this PR 🙏 @Ultimateutkarsh11

Comment on lines 38 to 42
if (!isCaptchaValid) {
toast.error('Captcha is not valid');
return;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this duplicate code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<p className="text-sm font-semibold mb-2 text-red-600">
{error.password}
</p>
<CaptchaUser onChange={(isValid) => setIsCaptchaValid(isValid)} /> {/* Add Captcha component */}
</div>
<CaptchaUser onChange={(isValid) => setIsCaptchaValid(isValid)} />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove captcha from here since already present

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 6, 2024

@Ultimateutkarsh11 Please review this pr if changes exists let me know :)

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 6, 2024

@akbatra567 Thanks and also check this also 👍

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 7, 2024

@VaibhavArora314 merge this pr and have a look at pr #385

@VaibhavArora314 VaibhavArora314 merged commit 10a7e38 into VaibhavArora314:main Jul 7, 2024
3 checks passed
Copy link

github-actions bot commented Jul 7, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Reloading of posts due to searching
4 participants