-
Notifications
You must be signed in to change notification settings - Fork 66
Feat: Fixed Search Bar feature with search button successfully Issue 362 #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looking, just don't push changes of your other pr
frontend/src/App.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment these lines
Sorry It want happen again 🙏 |
@akbatra567 @Ultimateutkarsh11 Please review this pr, if any issue let me know 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there are some other changed in the PR, regarding adding captcha.
Could you remove them from this PR?
You merge the captcha PR and i will resolve the merge conflicts here |
PRs should be independent of one another, you can create multiple branches to divide code for each issue. If the other PR is not approved and this gets approved. It's not a good practice to have unrelated code and unapproved changes from the other PR might go unreviewed. |
@akbatra567 approve/review my other PR i will fix this one now only ! |
Done |
@akbatra567 please review this PR 🙏 @Ultimateutkarsh11 |
frontend/src/pages/Signin.tsx
Outdated
if (!isCaptchaValid) { | ||
toast.error('Captcha is not valid'); | ||
return; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this duplicate code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @akbatra567
<p className="text-sm font-semibold mb-2 text-red-600"> | ||
{error.password} | ||
</p> | ||
<CaptchaUser onChange={(isValid) => setIsCaptchaValid(isValid)} /> {/* Add Captcha component */} | ||
</div> | ||
<CaptchaUser onChange={(isValid) => setIsCaptchaValid(isValid)} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove captcha from here since already present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @VaibhavArora314
@Ultimateutkarsh11 Please review this pr if changes exists let me know :) |
@akbatra567 Thanks and also check this also 👍 |
@VaibhavArora314 merge this pr and have a look at pr #385 |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Pull Request Resolve [#362 ]
Title: Fixed Search Bar feature with search button successfully.
Description
Related Issues
Fixes #362
Changes Made
New features: Fixed Search Bar feature with search button.
Screenshots
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.