-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Removed like/dislikes and created logic for reactions on leaderboard successfully issue 379 #392
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good to me, just add translations for "Reaction" in other languages
Done 👍 |
@Ultimateutkarsh11 can you review this please 😀 |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Is this any backend code for this ? |
In this pull request, the contributor had to search the backend for any like-dislike functionality api logic left to replace it completely with reactions logic and initially I thought this would be level 3. Though after the pull request was raised, I found that all the logic was previously removed but still the contributor had to make sure that this logic was not left anywhere in the backend and that's why it was still given level 3. If there is any problem then I can reduce the level to 2. @sanjay-kv |
down to level2, as of now i can see used the same logic by changing less code or previous functionality |
done 👍 |
Pull Request Resolves [#379 ]
Title: Removed like/dislikes and created logic for reactions on leaderboard successfully.
Description
Related Issues
Fixes #379
Changes Made
New features: Removed like/dislikes and created logic for reactions on leaderboard.
Screenshots
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.