Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Removed like/dislikes and created logic for reactions on leaderboard successfully issue 379 #392

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 8, 2024

Pull Request Resolves [#379 ]

Title: Removed like/dislikes and created logic for reactions on leaderboard successfully.

Description

  1. In backend, I removed the like and dislike from the prisma file, also removed the like/dislike from the post and admin controller.
  2. I written the new leaderboard controller logic to fetched the top 10 user with most reactions.
  3. In frontend, updated the ILeaderboardUser interface and also the LeaderboardUser.tsx for fetching the users.

Related Issues

Fixes #379

Changes Made

New features: Removed like/dislikes and created logic for reactions on leaderboard.

Screenshots

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 1:34pm

Copy link

github-actions bot commented Jul 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me, just add translations for "Reaction" in other languages

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 8, 2024

looking good to me, just add translations for "Reaction" in other languages

Done 👍

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 9, 2024

@Ultimateutkarsh11 can you review this please 😀

@Ultimateutkarsh11 Ultimateutkarsh11 merged commit 712505c into VaibhavArora314:main Jul 9, 2024
3 checks passed
Copy link

github-actions bot commented Jul 9, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@sanjay-kv
Copy link

Is this any backend code for this ?

GSSoC24/Contributor#490

@VaibhavArora314
Copy link
Owner

Is this any backend code for this ?

GSSoC24/Contributor#490

In this pull request, the contributor had to search the backend for any like-dislike functionality api logic left to replace it completely with reactions logic and initially I thought this would be level 3. Though after the pull request was raised, I found that all the logic was previously removed but still the contributor had to make sure that this logic was not left anywhere in the backend and that's why it was still given level 3. If there is any problem then I can reduce the level to 2. @sanjay-kv

@sanjay-kv
Copy link

down to level2, as of now i can see used the same logic by changing less code or previous functionality

@VaibhavArora314
Copy link
Owner

down to level2, as of now i can see used the same logic by changing less code or previous functionality

done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Leaderboard Logic and remove like-dislike logic
5 participants