Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Integrated the feedback with the Testimonial in style share successfully issue 526 #533

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 29, 2024

Pull Request Resolves [ #526 ]

Title: Integrating the feedback with the Testimonial in style share successfully.

Description

  1. In backend, I created a route and controller to get all the feedback from the database.
  2. In frontend, I get the api in the Testimonial section.
  3. The design is responsive.

Related Issues

Fixes #526

Changes Made

New feature: Integrated the feedback with the Testimonial in style share.

Screenshots

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 3:54pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of simply showing the feedback of all the users, you can do one thing: add a visible property to the feedback model which is by default false, and in the admin panel, we can set the visible property to true. Only feedback that is marked visible by the admin will be shown in the testimonials section. I will make this level 3 due to the increased work of integrating into the admin panel if you are willing to make these changes.

@VaibhavArora314
Copy link
Owner

if it's too much you can tell, we can merge it as it is as level 2 without the changes.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 30, 2024

if it's too much you can tell, we can merge it as it is as level 2 without the changes.

Yha give it level 2 because there are lot of works still pending in my college, projects and all, You can merge it.
Time issue is their.
Thank You @VaibhavArora314 but I will implement it when I will get time not just for GSSOC 👍

@Ultimateutkarsh11 Ultimateutkarsh11 merged commit bfcab16 into VaibhavArora314:main Jul 31, 2024
4 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@Ultimateutkarsh11 Ultimateutkarsh11 added enhancement New feature or request level2 labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GSSOC level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Integrating the feedback with the Testimonial in style share
4 participants