Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Showing users ratings in Testimonials and also using best coding practices successfully issue 566 #567

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Aug 5, 2024

Pull Request Resolves [ #566 ]

Title: Showing users ratings in Testimonials and also using best coding practices successfully.

Description

  1. In frontend, I created a separate interface in types.tsx for managing all the interface in single place.
  2. The code is reduced in the Testimonials section also using rating I am fetching the user ratings.
  3. I modified the Testimonial design.
  4. The design is responsive.

Related Issues

Fixes #566

Changes Made

New feature: Showing users ratings in Testimonials and also using best coding practices.

Screenshots

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 2:24pm

Copy link

github-actions bot commented Aug 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@akbatra567 akbatra567 merged commit c6b5f73 into VaibhavArora314:main Aug 6, 2024
4 checks passed
Copy link

github-actions bot commented Aug 6, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Aug 6, 2024

@akbatra567 give level 2 the issue was of level 2 not level 1!

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Aug 6, 2024

@VaibhavArora314 please give level 2 and you only add the labels and level at the spot the PR is generated else it create confusion and waste the time also.

I hope you consider my request.
Thank You,
Meet Dodiya

@VaibhavArora314
Copy link
Owner

VaibhavArora314 commented Aug 6, 2024

@VaibhavArora314 please give level 2 and you only add the labels and level at the spot the PR is generated else it create confusion and waste the time also.

I hope you consider my request.
Thank You,
Meet Dodiya

There must have been some confusion from Akshit's side. Sorry for any inconveniences.

The whole purpose of the label assignment on issue is to identify the level of work unless there is some confusion to what will be the level of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Showing the stars in the testimonials given by the users
3 participants