Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Home Page UI, Added About US, Added Recent 6 Posts from pagination API successfully Issue 4 #78

Merged

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jun 2, 2024

Pull Request Resolves[#4]

Title: Updated Home Page UI, Added About US, Added Recent 6 Posts from pagination API.

Description

  1. Updated HomePage UI.
  2. Added About Us page with self made image without an copyright issues.
  3. Added recent 6 posts from pagination api.
  4. All process is done keeping responsiveness in mind.

Related Issues

Fixes #4

Changes Made

Improvements in Home page UI.
New Features : About Us and Recent Posts sections.

Screenshots

  1. Hero Section.

image

  1. About Us Section.

image

  1. 6 latest Posts.

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 5:59am

Copy link

github-actions bot commented Jun 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, just 2 things

  1. about and hero images are too big, especially about image is over 5mb
  2. remove vite.config.ts.timestamp file

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 2, 2024

Okay i will do the changes !

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 2, 2024

@VaibhavArora314 I had compressed the image size to KB's

Copy link
Collaborator

@Ultimateutkarsh11 Ultimateutkarsh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MeetDOD, the website looks much better now!

@VaibhavArora314
Copy link
Owner

Resolve merge conflicts, rest is good

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 3, 2024

@VaibhavArora314 Done 👍

@VaibhavArora314 VaibhavArora314 merged commit 9aee34e into VaibhavArora314:main Jun 3, 2024
3 checks passed
Copy link

github-actions bot commented Jun 3, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Home page of the website
3 participants