Skip to content

Comments

Context: strict_braket_symmetry -> assert_strict_braket_symmetry#499

Merged
evaleev merged 2 commits intomasterfrom
498-contextstrict_braket_symmetry-can-be-misleading
Feb 18, 2026
Merged

Context: strict_braket_symmetry -> assert_strict_braket_symmetry#499
evaleev merged 2 commits intomasterfrom
498-contextstrict_braket_symmetry-can-be-misleading

Conversation

@evaleev
Copy link
Member

@evaleev evaleev commented Feb 18, 2026

rename Context::strict_braket_symmetry introduced in #495 to emphasize that the bra-ket TN strictness checks are assertions, and will be disabled completely if SeQuant is configured with SEQUANT_ASSERT_BEHAVIOR=IGNORE

@evaleev evaleev linked an issue Feb 18, 2026 that may be closed by this pull request
@evaleev evaleev requested review from Krzmbrzl and Copilot February 18, 2026 14:14
@evaleev evaleev added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Feb 18, 2026
@evaleev evaleev added this to the 2.2 milestone Feb 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@evaleev evaleev force-pushed the 498-contextstrict_braket_symmetry-can-be-misleading branch from 16fb194 to 98d6902 Compare February 18, 2026 16:48
@evaleev evaleev merged commit 63949a1 into master Feb 18, 2026
16 checks passed
@evaleev evaleev deleted the 498-contextstrict_braket_symmetry-can-be-misleading branch February 18, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context::strict_braket_symmetry can be misleading

2 participants