Take advantage of Monobehavior implicit cast to bool and use bool che…

…ck instead of counter
Valheim-Modding · Nov 18, 2023 · f7441aa · f7441aa
1 parent b2220bf
commit f7441aa
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/JotunnLib/Extensions/GameObjectExtension.cs b/JotunnLib/Extensions/GameObjectExtension.cs
@@ -151,19 +151,14 @@ public static bool HasAnyComponent(this GameObject gameObject, params string[] c
         /// <returns></returns>
         public static bool HasAllComponents(this GameObject gameObject, params string[] componentNames)
         {
-            int compCount = 0;
             foreach (var name in componentNames)
             {
-                if (gameObject.GetComponent(name))
-                {
-                    compCount++;
-                }
-                else
+                if (!gameObject.GetComponent(name))
                 {
                     return false;
                 }
             }
-            return compCount == componentNames.Length;
+            return true;
         }
 
         /// <summary>
@@ -174,19 +169,14 @@ public static bool HasAllComponents(this GameObject gameObject, params string[]
         /// <returns></returns>
         public static bool HasAllComponents(this GameObject gameObject, params Type[] components)
         {
-            int compCount = 0;
             foreach (var compo in components)
             {
-                if (gameObject.GetComponent(compo))
-                {
-                    compCount++;
-                }
-                else
+                if (!gameObject.GetComponent(compo))
                 {
                     return false;
                 }
             }
-            return compCount == components.Length;
+            return true;
         }
 
         /// <summary>