Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions for GameObject, Transform, and String to provide convience methods #416

Merged
merged 28 commits into from
Nov 18, 2023
Merged

Extensions for GameObject, Transform, and String to provide convience methods #416

merged 28 commits into from
Nov 18, 2023

Commits on Nov 17, 2023

  1. Add Transform.FindDeepChild extension

    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    622f9af View commit details
    Browse the repository at this point in the history

  2. Add string extensions for handling substrings, prefixes, and suffixes

    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    923b82f View commit details
    Browse the repository at this point in the history

  3. Add string extension to help with formatting piece names to match Van… 

    …illa formatting
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5115e84 View commit details
    Browse the repository at this point in the history

  4. Add extension to convert a null string to an empty string to prevent … 

    …type error if needed
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    feacd85 View commit details
    Browse the repository at this point in the history

  5. Fix access modifiers

    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a881562 View commit details
    Browse the repository at this point in the history

  6. Fix access modifiers to be public

    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    dfb2342 View commit details
    Browse the repository at this point in the history

  7. GameObject extension to check if gameObject has a component, used to … 

    …improve readability of code or force null result to be a bool instead
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    24eca2a View commit details
    Browse the repository at this point in the history

  8. Extensions method (with overloads) to check if gameObject contains an… 

    … instance of any one of the given components
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5ed7695 View commit details
    Browse the repository at this point in the history

  9. Extension method (with overloads) to check if a gameObject has all of… 

    … the given components.
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0b979ec View commit details
    Browse the repository at this point in the history

  10. Extension method to check if gameObject has any of the given componen… 

    …ts in any of its children.
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5c28bf3 View commit details
    Browse the repository at this point in the history

  11. Extension method to check if gameObject or any of it's children has a… 

    … component. Intended to improve readability or force null result to a bool if needed
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d2d7f74 View commit details
    Browse the repository at this point in the history

  12. Extension method to search for a specific component based on the name… 

    … of the child object it is attached to.
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5b507f6 View commit details
    Browse the repository at this point in the history

  13. Extension to expose the Transform extension FindDeepChild as a method… 

    … for GameObject
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    310f1f5 View commit details
    Browse the repository at this point in the history

  14. Improved parameter descriptions

    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    43a011e View commit details
    Browse the repository at this point in the history

  15. Fix build failure due to ambiguous reference to Object introduced by … 

    …new extension methods using System
    @searica
    searica committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1d08d21 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Update JotunnLib/Extensions/GameObjectExtension.cs 

    Co-authored-by: Maximilian Schmöcker <39767545+MSchmoecker@users.noreply.github.com>
    @searica @MSchmoecker
    searica and MSchmoecker authored Nov 18, 2023
    Configuration menu
    Copy the full SHA
    3ff63a5 View commit details
    Browse the repository at this point in the history

  2. Wrap Vanilla Valheim method instead of using custom version

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    7ae8bbc View commit details
    Browse the repository at this point in the history

  3. Remove redundant methods

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    9518875 View commit details
    Browse the repository at this point in the history

  4. Remove null checks

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    2eff6f8 View commit details
    Browse the repository at this point in the history

  5. Fix missing param in doc

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    f799a32 View commit details
    Browse the repository at this point in the history

  6. Better accomplished by using Utils.FindChild() + GetComponent() so re… 

    …move redundant method
    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    3c9b434 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded null check

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    20643f9 View commit details
    Browse the repository at this point in the history

  8. This method is redundant and can be written as string ?? string.Empty… 

    … or string ?? ""
    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    6d1bee6 View commit details
    Browse the repository at this point in the history

  9. Rewrite to avoid null checks, not sure if I could just use if (!gameO… 

    …bject.GetComponent(name)) instead though?
    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    030b8c8 View commit details
    Browse the repository at this point in the history

  10. Remove redundant method

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    bebcbbc View commit details
    Browse the repository at this point in the history

  11. Merge branch 'Extensions' of https://github.com/searica/Jotunn into E… 

    …xtensions
    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    64c0300 View commit details
    Browse the repository at this point in the history

  12. Fix doc format

    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    b2220bf View commit details
    Browse the repository at this point in the history

  13. Take advantage of Monobehavior implicit cast to bool and use bool che… 

    …ck instead of counter
    @searica
    searica committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    f7441aa View commit details
    Browse the repository at this point in the history