-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add End-of-round #11
base: main
Are you sure you want to change the base?
Add End-of-round #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some change requests for you to look at.
Let us know if you want to work on these or want us to do them at some point in the future :)
Latest animation test: Ani_test.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor things I'm mostly suggesting because we'll merge this in once we have a cool background image (and that might take a bit).
No worries if you can't get to it tho :D
When testing a few images, I noticed that during the end phase the buttons already switched to the shopping phase ones - this shouldn't happen. Take a look here for the button logic. |
in 3e63a4e, I added endround button logic, which it should hide "Change Stats" on "end" round phrase. I could get those rest hidden on endround but it's up to you if you want that implemented |
Waiting on art assets, merging after :) |
Looking forward to it 😃 |
Introduction
Same as #10, this will add a banner and animations after the match reach the:end state. After 4 seconds the banner falls down to the bottom of the screen for better observation:
Endround_Preview_final.mov
Current State: