Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add End-of-round #11

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

b4iterdev
Copy link
Contributor

Introduction

Same as #10, this will add a banner and animations after the match reach the:end state. After 4 seconds the banner falls down to the bottom of the screen for better observation:

Endround_Preview_final.mov

Current State:

  • First appearance might have slight lag, might be due to css animation. Overall this should not be an issue as it only happens at first.
  • Confirmed to be working properly on first half. The second half, however, is untested whenever it is displaying properly or not.

@b4iterdev b4iterdev mentioned this pull request Dec 17, 2024
@DarkView DarkView marked this pull request as ready for review December 17, 2024 17:18
Copy link
Member

@DarkView DarkView left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some change requests for you to look at.
Let us know if you want to work on these or want us to do them at some point in the future :)

src/app/endround/endround.component.ts Show resolved Hide resolved
src/app/endround/endround.component.ts Outdated Show resolved Hide resolved
src/app/endround/endround.component.scss Show resolved Hide resolved
src/app/endround/endround.component.scss Outdated Show resolved Hide resolved
public/assets/misc/endround-bg.png Outdated Show resolved Hide resolved
@b4iterdev b4iterdev requested a review from DarkView December 18, 2024 04:31
@b4iterdev
Copy link
Contributor Author

Latest animation test:

Ani_test.mov

@b4iterdev b4iterdev changed the title Add End-of-round (UNTESTED) Add End-of-round Dec 19, 2024
Copy link
Member

@DarkView DarkView left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor things I'm mostly suggesting because we'll merge this in once we have a cool background image (and that might take a bit).
No worries if you can't get to it tho :D

src/app/testing/testing.component.ts Outdated Show resolved Hide resolved
src/app/endround/endround.component.html Outdated Show resolved Hide resolved
@DarkView
Copy link
Member

When testing a few images, I noticed that during the end phase the buttons already switched to the shopping phase ones - this shouldn't happen. Take a look here for the button logic.

@b4iterdev
Copy link
Contributor Author

When testing a few images, I noticed that during the end phase the buttons already switched to the shopping phase ones - this shouldn't happen. Take a look here for the button logic.

in 3e63a4e, I added endround button logic, which it should hide "Change Stats" on "end" round phrase. I could get those rest hidden on endround but it's up to you if you want that implemented
image

@DarkView
Copy link
Member

Waiting on art assets, merging after :)

@ConnorDoesDev
Copy link

Waiting on art assets, merging after :)

Looking forward to it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants