Skip to content

refactor: use run_in_threadpool for asset service calls in watchlist router #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcfgv merged 1 commit into from
Oct 28, 2025
Merged

refactor: use run_in_threadpool for asset service calls in watchlist router #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions python/valuecell/server/api/routers/watchlist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import List, Optional

from fastapi import APIRouter, HTTPException, Path, Query
from starlette.concurrency import run_in_threadpool

from ....utils.i18n_utils import parse_and_validate_utc_dates
from ...db.repositories.watchlist_repository import get_watchlist_repository
Expand Down Expand Up @@ -60,7 +61,8 @@ async def search_assets(
countries_list = countries.split(",") if countries else None

# Perform search using asset service
result = asset_service.search_assets(
result = await run_in_threadpool(
asset_service.search_assets,
query=q,
asset_types=asset_types_list,
exchanges=exchanges_list,
Expand Down Expand Up @@ -106,7 +108,9 @@ async def get_asset_detail(
):
"""Get detailed asset information."""
try:
result = asset_service.get_asset_info(ticker, language=language)
result = await run_in_threadpool(
asset_service.get_asset_info, ticker, language=language
)

if not result.get("success", False):
if "not found" in result.get("error", "").lower():
Expand Down Expand Up @@ -145,7 +149,9 @@ async def get_asset_price(
):
"""Get current asset price."""
try:
result = asset_service.get_asset_price(ticker, language=language)
result = await run_in_threadpool(
asset_service.get_asset_price, ticker, language=language
)

if not result.get("success", False):
if "not available" in result.get("error", "").lower():
Expand Down Expand Up @@ -225,7 +231,8 @@ async def get_watchlist(
"""Get a specific watchlist."""
try:
# Use asset service to get watchlist with prices
result = asset_service.get_watchlist(
result = await run_in_threadpool(
asset_service.get_watchlist,
user_id=DEFAULT_USER_ID,
watchlist_name=watchlist_name,
include_prices=include_prices,
Expand Down Expand Up @@ -517,8 +524,13 @@ async def get_asset_historical_prices(
start_dt, end_dt = parse_and_validate_utc_dates(start_date, end_date)

# Get historical price data
result = asset_service.get_historical_prices(
ticker, start_dt, end_dt, interval, language
result = await run_in_threadpool(
asset_service.get_historical_prices,
ticker,
start_dt,
end_dt,
interval,
language,
)

if not result.get("success", False):
Expand Down