Skip to content

Conversation

@vcfgv
Copy link
Collaborator

@vcfgv vcfgv commented Oct 29, 2025

📝 Pull Request Template

1. Related Issue

Closes # (issue number)

Type of Change (select one)

Bug Fix

3. Description

Please describe the changes made and why they are necessary.

4. Testing

  • I have tested this locally.
  • I have updated or added relevant tests.

5. Checklist

@vcfgv vcfgv added this to the Integrate More Model Providers milestone Oct 29, 2025
@vcfgv vcfgv marked this pull request as ready for review October 29, 2025 04:52
@vcfgv vcfgv requested a review from hazeone October 29, 2025 05:30
@vcfgv vcfgv changed the title bugfix: model config None check and flexible json mode decision bugfix: model config robustness, default embedder, flexible json mode decision Oct 29, 2025
Copy link
Contributor

@hazeone hazeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hazeone hazeone merged commit 2dfbcf8 into main Oct 29, 2025
3 checks passed
@hazeone hazeone deleted the bugfix/model-config-nonetype-and-json-mode branch October 29, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants