Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions python/valuecell/core/coordinate/orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from valuecell.core.types import (
MessageChunk,
MessageChunkMetadata,
MessageChunkStatus,
MessageDataKind,
UserInput,
)
Expand All @@ -35,12 +36,15 @@ def _create_message_chunk(
user_id: str,
kind: MessageDataKind = MessageDataKind.TEXT,
is_final: bool = False,
status: MessageChunkStatus = MessageChunkStatus.partial,
) -> MessageChunk:
"""Create a MessageChunk with common metadata"""
return MessageChunk(
content=content,
kind=kind,
meta=MessageChunkMetadata(session_id=session_id, user_id=user_id),
meta=MessageChunkMetadata(
session_id=session_id, user_id=user_id, status=status
),
is_final=is_final,
)

Expand All @@ -53,6 +57,7 @@ def _create_error_message_chunk(
session_id=session_id,
user_id=user_id,
is_final=True,
status=MessageChunkStatus.failure,
)

async def process_user_input(
Expand Down Expand Up @@ -97,8 +102,8 @@ async def _execute_plan(

session_id, user_id = metadata["session_id"], metadata["user_id"]
if not plan.tasks:
yield self._create_message_chunk(
"No tasks found for this request.", session_id, user_id, is_final=True
yield self._create_error_message_chunk(
"No tasks found for this request.", session_id, user_id
)
return

Expand All @@ -116,15 +121,6 @@ async def _execute_plan(
error_msg = f"Error executing {task.agent_name}: {str(e)}"
yield self._create_error_message_chunk(error_msg, session_id, user_id)

# Check if no results were produced
if not plan.tasks:
yield self._create_message_chunk(
"No agents were able to process this request.",
session_id,
user_id,
is_final=True,
)

async def _execute_task(
self, task, query: str, metadata: dict
) -> AsyncGenerator[MessageChunk, None]:
Expand Down Expand Up @@ -165,11 +161,10 @@ async def _execute_task(
if event.status.state == TaskState.failed:
err_msg = get_message_text(event.status.message)
await self.task_manager.fail_task(task.task_id, err_msg)
yield self._create_message_chunk(
yield self._create_error_message_chunk(
err_msg,
task.session_id,
task.user_id,
is_final=True,
)
return

Expand All @@ -184,7 +179,11 @@ async def _execute_task(
# Complete task
await self.task_manager.complete_task(task.task_id)
yield self._create_message_chunk(
"", task.session_id, task.user_id, is_final=True
"",
task.session_id,
task.user_id,
is_final=True,
status=MessageChunkStatus.success,
)

except Exception as e:
Expand Down
11 changes: 11 additions & 0 deletions python/valuecell/core/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,18 @@ class MessageDataKind(str, Enum):
COMMAND = "command"


class MessageChunkStatus(str, Enum):
partial = "partial"
success = "success"
failure = "failure"
cancelled = "cancelled"


class MessageChunkMetadata(BaseModel):
status: MessageChunkStatus = Field(
default=MessageChunkStatus.partial,
description="Chunk outcome: use partial for intermediate chunks; success/failure for final.",
)
session_id: str = Field(..., description="Session ID for this request")
user_id: str = Field(..., description="User ID who made this request")

Expand Down