Skip to content

fix(datasource): watchlist search error #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
su8su merged 3 commits into from
Nov 1, 2025
Merged

fix(datasource): watchlist search error #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2a0e87
fix: function is not found error
hazeone Nov 1, 2025
b0b8682
fix: can't get the right data from yfinance
hazeone Nov 1, 2025
3a260f7
lint
hazeone Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/valuecell/adapters/assets/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,9 @@ def _fallback_search_assets(
if ":" not in ticker:
continue

if not self.get_adapter_for_ticker(ticker):
continue

# Try to get asset info
try:
asset_info = self.get_asset_info(ticker)
Expand Down
9 changes: 2 additions & 7 deletions python/valuecell/adapters/assets/yfinance_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def _create_search_result_from_quote(
)

# Validate the ticker format
if not self._is_valid_internal_ticker(internal_ticker):
if not self.validate_ticker(internal_ticker):
logger.debug(
f"Invalid ticker format after conversion: {internal_ticker}"
)
Expand Down Expand Up @@ -170,11 +170,6 @@ def _create_search_result_from_quote(
"en-GB": long_name or short_name,
}

# Calculate relevance score based on match quality
relevance_score = self._calculate_search_relevance(
quote, symbol, long_name or short_name
)

# Create search result
search_result = AssetSearchResult(
ticker=internal_ticker,
Expand All @@ -184,7 +179,6 @@ def _create_search_result_from_quote(
country=country,
currency=quote.get("currency", "USD"),
market_status=MarketStatus.UNKNOWN,
relevance_score=relevance_score,
)

# Save asset metadata to database for future lookups
Expand Down Expand Up @@ -234,6 +228,7 @@ def get_asset_info(self, ticker: str) -> Optional[Asset]:
long_name = info.get("longName", info.get("shortName", ticker))
names.set_name("en-US", long_name)

exchange = None
if info.get("exchange"):
exchange = self.exchange_mapping.get(info.get("exchange"))

Expand Down