Skip to content

refactor: update strategy type naming in schemas and router #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
su8su merged 1 commit into from
Nov 20, 2025
Merged

refactor: update strategy type naming in schemas and router #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions python/valuecell/server/api/routers/strategy_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from valuecell.core.coordinate.orchestrator import AgentOrchestrator
from valuecell.core.types import CommonResponseEvent, UserInput, UserInputMetadata
from valuecell.server.api.schemas.base import SuccessResponse
from valuecell.server.api.schemas.strategy import StrategyType as StrategySummaryType
from valuecell.server.api.schemas.strategy import StrategyType
from valuecell.server.db.connection import get_db
from valuecell.server.db.repositories import get_strategy_repository
from valuecell.utils.uuid import generate_conversation_id, generate_uuid
Expand All @@ -33,8 +33,8 @@ def create_strategy_agent_router() -> APIRouter:
@router.post("/create")
async def create_strategy_agent(
request: UserRequest,
strategy_type: StrategySummaryType = Query(
default=StrategySummaryType.PROMPT,
strategy_type: StrategyType = Query(
default=StrategyType.PROMPT,
description="'prompt based strategy' or 'grid strategy'",
),
db: Session = Depends(get_db),
Expand Down Expand Up @@ -105,9 +105,9 @@ async def create_strategy_agent(
query = user_request.model_dump_json()

# Select target agent based on strategy_type (enum)
if strategy_type == StrategySummaryType.PROMPT:
if strategy_type == StrategyType.PROMPT:
agent_name = "PromptBasedStrategyAgent"
elif strategy_type == StrategySummaryType.GRID:
elif strategy_type == StrategyType.GRID:
agent_name = "GridStrategyAgent"
else:
raise HTTPException(
Expand Down
4 changes: 2 additions & 2 deletions python/valuecell/server/api/schemas/strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@


class StrategyType(str, Enum):
PROMPT = "prompt based strategy"
GRID = "grid strategy"
PROMPT = "PromptBasedStrategy"
GRID = "GridStrategy"


class StrategySummaryData(BaseModel):
Expand Down