Skip to content

fix: fix strategy agent in conversation list #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DigHuang merged 1 commit into from
Nov 21, 2025
Merged

fix: fix strategy agent in conversation list #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions python/valuecell/server/services/conversation_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@
)
from valuecell.utils import resolve_db_path

# Agent names used by strategy creation flows; conversations from these agents
# should be excluded from the general conversation list returned to clients.
# Keep this set small and focused; extend if new strategy agents are added.
STRATEGY_AGENT_NAMES = {
"PromptBasedStrategyAgent",
"GridStrategyAgent",
}


class ConversationService:
"""Service for managing conversation operations."""
Expand Down Expand Up @@ -51,6 +59,20 @@ async def get_conversation_list(
user_id=user_id
)

# Exclude conversations initiated by strategy agents from general listing.
# We match by known names and a conservative substring check to future-proof.
conversations = [
conv
for conv in conversations
if not (
(conv.agent_name or "") in STRATEGY_AGENT_NAMES
or (
(conv.agent_name or "")
and "StrategyAgent" in (conv.agent_name or "")
)
)
]

# Apply pagination
total = len(conversations)

Expand Down