Skip to content

fix(TradingAgent): add model validator in TradeDecisionItem #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcfgv merged 1 commit into from
Nov 25, 2025
Merged

fix(TradingAgent): add model validator in TradeDecisionItem #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions python/valuecell/agents/common/trading/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,23 @@ class TradeDecisionItem(BaseModel):
default=None, description="Optional natural language rationale"
)

# TODO: Remove this validator when the model supports InstrumentRef.
@model_validator(mode="before")
@classmethod
def _normalize_instrument(cls, data):
"""Normalize instrument field: allow string shorthand for InstrumentRef.

Some LLMs return instrument as a plain string (e.g., "ETH/USDT") instead
of an object {"symbol": "ETH/USDT"}. This validator handles both formats.
"""
if not isinstance(data, dict):
return data
values = dict(data)
instrument = values.get("instrument")
if isinstance(instrument, str):
values["instrument"] = {"symbol": instrument}
return values


class TradePlanProposal(BaseModel):
"""Structured output before rule normalization."""
Expand Down