Skip to content

fix: prevent redundant fee deduction from account balance #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
su8su merged 1 commit into from
Nov 26, 2025
Merged

fix: prevent redundant fee deduction from account balance #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/valuecell/agents/common/trading/_internal/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ def _create_trades(
exit_ts=exit_ts,
trade_ts=timestamp_ms,
holding_ms=(exit_ts - entry_ts_prev) if entry_ts_prev else None,
unrealized_pnl=0.0,
realized_pnl=realized_pnl,
realized_pnl_pct=realized_pnl_pct,
# For a full close, reflect the leverage of the closed position, not the closing instruction
Expand Down
2 changes: 1 addition & 1 deletion python/valuecell/agents/common/trading/portfolio/in_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def apply_trades(
else:
# Derivatives: Cash (Wallet Balance) only changes by Realized PnL and Fees
# Notional is not deducted from cash.
self._view.account_balance -= fee
# self._view.account_balance -= fee
self._view.account_balance += realized_delta

total_realized += realized_delta
Expand Down