Skip to content

Conversation

@vcfgv
Copy link
Collaborator

@vcfgv vcfgv commented Nov 27, 2025

📝 Pull Request Template

1. Related Issue

Closes # (issue number)

2. Type of Change (select one)

Bug Fix

3. Description

On Windows, ⁠taskkill was unable to achieve the same effect as ⁠Ctrl+C (KeyboardInterrupt) on macOS, leading to forced termination without proper cleanup.

Fix Details:

  • Implemented IPC via ⁠stdin to control the process lifecycle.
  • The server now accepts a termination signal through stdin, triggering the existing graceful exit logic.

4. Testing

  • I have tested this locally.
  • I have updated or added relevant tests.

5. Checklist

@vcfgv vcfgv marked this pull request as ready for review November 27, 2025 09:09
@vcfgv vcfgv requested a review from DigHuang November 27, 2025 09:13
Copy link
Contributor

@hazeone hazeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hazeone hazeone merged commit e0a7c62 into main Nov 27, 2025
6 checks passed
@hazeone hazeone deleted the bugfix/tauri-request-graceful-then-kill branch November 27, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants