Skip to content

Conversation

@byronwang2005
Copy link
Contributor

📝 Pull Request Template

1. Related Issue

Fixes the broken DashScope support introduced in PR “Feat/support dashscope” (previous integration was non‑native and unusable).

2. Type of Change (select one)

Type of Change: Bug Fix

3. Description

  • Implement native DashScope HTTP integration and align with Agno’s structured output logic:
    • Explicitly disable native structured outputs on the DashScope model to avoid incorrect paths
      • python/valuecell/adapters/models/factory.py:655-656
    • Force JSON mode for DashScope models to ensure reliable parsing
      • python/valuecell/utils/model.py:60-63
  • Frontend settings: hide “API Host” field for DashScope to prevent confusion (DashScope native does not need base_url)
    • frontend/src/app/setting/components/models/model-detail.tsx:219-235
  • Format and annotate DashScope provider YAML to match other providers (no semantic changes)
    • python/configs/providers/dashscope.yaml:1-83
  • Notes on native endpoints (for clarity):
    • Text generation endpoint is hardcoded to the official host
      • python/valuecell/adapters/models/factory.py:684
    • Embedding endpoint likewise uses official host
      • python/valuecell/adapters/models/factory.py:591-593

4. Testing

  • I have tested this locally.
  • I have updated or added relevant tests.

5. Checklist

@vcfgv
Copy link
Collaborator

vcfgv commented Nov 27, 2025

link: #441

@vcfgv vcfgv changed the title Fix: Broken DashScope support introduced in PR “feat: Add DashScope provider support for Qwen3 models #441” (previous integration was non‑native and unusable). Fix: Broken DashScope support introduced in PR 441 (previous integration was non‑native and unusable) Nov 27, 2025
@hazeone
Copy link
Contributor

hazeone commented Nov 27, 2025

Please review this PR: #451. I resolved this issue.

@hazeone hazeone closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants