Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions python/valuecell/server/api/routers/strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from sqlalchemy import and_, or_
from sqlalchemy.orm import Session

from valuecell.server.api.schemas.base import SuccessResponse
from valuecell.server.api.schemas.base import StatusCode, SuccessResponse
from valuecell.server.api.schemas.strategy import (
StrategyCurveResponse,
StrategyDetailResponse,
Expand Down Expand Up @@ -211,11 +211,19 @@ async def get_strategy_performance(
id: str = Query(..., description="Strategy ID"),
) -> StrategyPerformanceResponse:
try:
# Fail for explicitly invalid IDs (prefix 'invalid'), but do not raise 404
raw_id = (id or "").strip()
if raw_id.lower().startswith("invalid"):
# Return HTTP 400 for invalid IDs
raise HTTPException(
status_code=StatusCode.BAD_REQUEST, detail="Invalid strategy id"
)

data = await StrategyService.get_strategy_performance(id)
if not data:
return SuccessResponse.create(
data=None,
msg="Strategy not found or no performance data",
# Strategy not found: return HTTP 404
raise HTTPException(
status_code=StatusCode.NOT_FOUND, detail="Strategy not found"
)

return SuccessResponse.create(
Expand Down