Skip to content

fix(backend): disable control thread for local development environment #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
su8su merged 1 commit into from
Dec 2, 2025
Merged

fix(backend): disable control thread for local development environment #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions python/valuecell/server/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from __future__ import annotations

import io
import os
import sys
import threading
from typing import Callable, Optional, TextIO
Expand Down Expand Up @@ -66,13 +67,23 @@ def request_stop() -> None:
server.should_exit = True
logger.info("Shutdown signal propagated to uvicorn")

control_thread = threading.Thread(
target=control_loop,
name="stdin-control",
args=(request_stop,),
daemon=True,
)
control_thread.start()
# In local development / IDE debug mode (ENV=local_dev) the interactive
# stdin wrapper (e.g. PyCharm debug) can cause attribute errors when
# iterating over `sys.stdin`. Skip creating the control thread in that
# environment to avoid crashing the background thread.
if os.getenv("ENV") == "local_dev":
logger.info(
"ENV=local_dev detected: skipping stdin control thread (IDE debug mode)"
)
control_thread = None
else:
control_thread = threading.Thread(
target=control_loop,
name="stdin-control",
args=(request_stop,),
daemon=True,
)
control_thread.start()

try:
server.run()
Expand Down