Skip to content

chore: update edgartools to version 4.34.0 #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcfgv merged 2 commits into from
Dec 2, 2025
Merged

chore: update edgartools to version 4.34.0 #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2642584
chore: update edgartools to version 4.34.0
vcfgv Dec 2, 2025
a080536
chore: refactor fetch_periodic_sec_filings and fetch_event_sec_filing…
vcfgv Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 14 additions & 6 deletions python/valuecell/agents/research_agent/sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import asyncio
import os
import re
from datetime import date, datetime
Expand Down Expand Up @@ -153,22 +154,27 @@ async def fetch_periodic_sec_filings(
List[SECFilingResult]
"""
req_forms = set(_ensure_list(forms)) or {"10-Q"}
company = Company(cik_or_ticker)
company = await asyncio.to_thread(lambda: Company(cik_or_ticker))

logger.info(f"Fetching filings for {cik_or_ticker} with params {req_forms}")
# If year is omitted, use latest(limit). Quarter without year is not supported.
if year is None:
if quarter is not None:
raise ValueError(
"quarter requires year to be specified for periodic filings"
)
filings = company.get_filings(form=list(req_forms)).latest(limit)
filings = await asyncio.to_thread(
lambda: company.get_filings(form=list(req_forms)).latest(limit)
)
if isinstance(filings, EntityFilings):
items = list(filings)
else:
items = [filings]
return await _write_and_ingest(items, Path(get_knowledge_path()))

filings = company.get_filings(form=list(req_forms), year=year, quarter=quarter)
filings = await asyncio.to_thread(
lambda: company.get_filings(form=list(req_forms), year=year, quarter=quarter)
)

return await _write_and_ingest(filings, Path(get_knowledge_path()))

Expand Down Expand Up @@ -199,19 +205,21 @@ async def fetch_event_sec_filings(
raise ValueError("start_date cannot be after end_date")

req_forms = set(_ensure_list(forms)) or {"8-K"}
company = Company(cik_or_ticker)
company = await asyncio.to_thread(lambda: Company(cik_or_ticker))

# If no date range specified, leverage edgar's latest(count) for efficiency
if not sd and not ed:
filings = company.get_filings(form=list(req_forms)).latest(limit)
filings = await asyncio.to_thread(
lambda: company.get_filings(form=list(req_forms)).latest(limit)
)
if isinstance(filings, EntityFilings):
items = list(filings)
else:
items = [filings]
return await _write_and_ingest(items, Path(get_knowledge_path()))

# Otherwise, fetch and filter by filing_date range
filings = company.get_filings(form=list(req_forms))
filings = await asyncio.to_thread(lambda: company.get_filings(form=list(req_forms)))
if isinstance(filings, EntityFilings):
items = list(filings)
else:
Expand Down